Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

better mutex and block pprof endpoints #737

Merged
merged 1 commit into from
Oct 10, 2017
Merged

better mutex and block pprof endpoints #737

merged 1 commit into from
Oct 10, 2017

Conversation

Dieterbe
Copy link
Contributor

api/pprof.go Outdated
}
rate, _ := strconv.Atoi(r.FormValue("rate"))
if rate == 0 {
rate = 10 * 000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should that be 10000?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops yes

api/pprof.go Outdated
}
rate, _ := strconv.Atoi(r.FormValue("rate"))
if rate == 0 {
rate = 10 * 000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be 10 * 1000

* allow specifying block rate, e.g. :
curl http://localhost:6060/debug/pprof/block\?seconds\=5\&rate\=1

* allow specifying mutex rate, e.g. :
curl http://localhost:6060/debug/pprof/mutex\?seconds\=30\&rate\=1
@Dieterbe
Copy link
Contributor Author

Dieterbe commented Oct 2, 2017

good now?

@Dieterbe
Copy link
Contributor Author

@woodsaj @replay good now?

@Dieterbe Dieterbe merged commit 5737d81 into master Oct 10, 2017
@Dieterbe Dieterbe deleted the extra-pprof branch September 18, 2018 09:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants